split out the tags into separate FuseProperty objects with the same weight #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
I've been playing with this; the main thing I don't like is the tags now tend to take precedence over the titles, even with the relative weights. This appears to be because of Fuse's concept of distance, the reason I couldn't find what I was looking for in the first place. An example is searching for "decode", which would pull up I think weighting the titles quite higher than one might be called for. |
deweyx
commented
Sep 17, 2020
| private static func parseTerms(terms: String?) -> [String] { | ||
| // reurn either an empty array or the terms split by comma space or semicolon | ||
| terms?.components(separatedBy: CharacterSet(charactersIn: ",; ")) ?? [String]() | ||
| } | ||
| } | ||
|
|
||
| extension Script: Fuseable { | ||
|
|
||
| var properties: [FuseProperty] { | ||
| return [ | ||
| FuseProperty(value: name, weight: 0.9), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I put together #166 (thanks for merging BTW!) I hadn't noticed the
Collapse.jsscript, though I had searched for "join" which is one of the tags on that script. Maybe it's partly because it's last in the list?This PR seems to fix search by any tag, even if it's later in a long list.